Client refactor #658
Merged
Client refactor #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `Func` from `MustDoFunc` and `DoFunc`. They were called that to differentiate from the old-style `Do` and `MustDo` which are no more. - Move sync functions to a new file. - Move registration/login functions to a new file. - Move `/internal/client` to `/client`.
Also fix bad merge conflict
S7evinK
approved these changes
Oct 4, 2023
| // Unsafe_SendEventUnsynced sends `e` into the room. This function is UNSAFE as it does not wait | ||
| // for the event to be fully processed. This can cause flakey tests. Prefer `SendEventSynced`. | ||
| // Returns the event ID of the sent event. | ||
| func (c *CSAPI) Unsafe_SendEventUnsynced(t TestLike, roomID string, e b.Event) string { |
There was a problem hiding this comment.
Suggested change
| func (c *CSAPI) Unsafe_SendEventUnsynced(t TestLike, roomID string, e b.Event) string { | |
| func (c *CSAPI) UnsafeSendEventUnsynced(t TestLike, roomID string, e b.Event) string { |
Maybe? (same for the others)
There was a problem hiding this comment.
I wanted to keep the _ to make it very clear that it's UNSAFE_SomeFuncName`, rather than just the function happens to have "unsafe" in the name.
There was a problem hiding this comment.
It should jump out at the reader as being dodgey is my point.
DMRobertson
reviewed
Oct 4, 2023
DMRobertson
reviewed
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FuncfromMustDoFuncandDoFunc. They were called that to differentiate from the old-styleDoandMustDowhich are no more./internal/clientto/client.TestLike, an interface to representtesting.Tto allow the client to be used outside of tests e.g benchmarks.Slightly not client related:
federation.Eventinstead of abusingb.Eventfor creating events over federation. Makes this much clearer and fixes Add client.Event #381Fixes #526 , #381
Partly addresses #226